Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the bugfixes from branch main into improve/V30 #172

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

s-heppner
Copy link
Contributor

This PR updates branch improve/V30 with the bugfixes done in branch main
in the mean time.

s-heppner and others added 6 commits August 22, 2023 10:03
Mypy appears to not like abstract classes in a context where only
concrete classes should be given:

```
Only concrete class can be given where
"tuple[type[Referable], KeyTypes]" is expected
```

However, the spec demands the four abstract classes
- `Event`
- `DataElement`
- `SubmodelElement`
- `SubmodelElementCollection`

to appear inside the `model.KeyTypes` Enum.
Therefore, we ignore these errors via `# type: ignore`.
The AAS Manager uses typehints to generate a list of possible types for
a value. Since `DateTimeStamp` was missing, it was impossible to store a
`DateTimeStamp` value via AAS Manager.
@s-heppner s-heppner marked this pull request as draft November 20, 2023 09:58
@s-heppner s-heppner marked this pull request as ready for review November 20, 2023 10:01
@s-heppner s-heppner added v3.0 BlockingRelease This issue needs to be solved before the pending release labels Nov 20, 2023
Copy link
Contributor

@jkhsjdhjs jkhsjdhjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the apparently incorrect merge of one line

test/adapter/xml/test_xml_deserialization.py Outdated Show resolved Hide resolved
@s-heppner s-heppner merged commit de82662 into improve/V30 Nov 21, 2023
11 checks passed
@s-heppner s-heppner deleted the merge/Bugfixes branch November 21, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BlockingRelease This issue needs to be solved before the pending release v3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants